Add sass-parser support for the @use rule
#2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
reviewed
Oct 16, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.79.7 | |||
There was a problem hiding this comment.
Not sure if it is intended, 1.79.6 has not been released.
If this would be placed before a string that would continue the escape, it would also continue the identifier itself.
Also add `ConfiguredVariable.raws.name` per recent discussions.
The original names make sense in isolation, but we want them to match our eventual `VarriableDeclaration` class. That class will need to have names that are sufficiently distinctive from the PostCSS `Declaration` type, so these prefigure that naming convention.
There's also a Declaration.variable in PostCSS u_u
Goodwine
requested changes
Oct 19, 2024
| comma?: boolean; | ||
|
|
||
| /** | ||
| * The whitespace between the final variable (or its trailing comma if it has |
There was a problem hiding this comment.
Can there be whitespace between the final variable and the comma? And if so, is that supposed to be stored in the raws for the variable? or for the config?
There was a problem hiding this comment.
Yes, it's stored in ConfiguredVariableRaws.afterValue.
Comment on lines
+125
to
+127
| } else if (this.defaultNamespace !== this.namespace) { | ||
| result += ' as ' + sassInternal.toCssIdentifier(this.namespace); | ||
| } |
There was a problem hiding this comment.
Assuming that I parse @use 'foo' as foo, and then do myUse.raws.namespace = 'bar' so that the RawValue is "invalid".
Should this line still omit producing as foo?
There was a problem hiding this comment.
Yes, myUse.raws.namespace is strictly ignored if it doesn't match.
Co-authored-by: Carlos (Goodwine) <2022649+Goodwine@users.noreply.github.com>
Goodwine
approved these changes
Oct 22, 2024
Co-authored-by: Carlos (Goodwine) <2022649+Goodwine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.